Do not create device when not using device#3279
Closed
zcbenz wants to merge 1 commit intoml-explore:mainfrom
Closed
Do not create device when not using device#3279zcbenz wants to merge 1 commit intoml-explore:mainfrom
zcbenz wants to merge 1 commit intoml-explore:mainfrom
Conversation
d38b379 to
fd8ddf3
Compare
fd8ddf3 to
935c985
Compare
Member
|
Hm the cache clearing could actually be a problem. The reason is that the C++ compiler cache can outlive the python interpreter and it will keep python data that when destroyed will try to acquire the GIL which is not available since the python interpreter has exited. |
Collaborator
Author
|
Ah that makes sense, it would be a lot more tricky to ensure thread safety then, I'll revisit this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default_device()on initialization.std::map.