Skip to content

Use nb::ndarray for checking arrays #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Mar 25, 2026
+5 −8
Merged

Use nb::ndarray for checking arrays #3283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions python/src/indexing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
#include <optional>
#include <sstream>

#include "python/src/convert.h"
#include "python/src/indexing.h"
#include <nanobind/ndarray.h>

#include "mlx/ops.h"
#include "python/src/convert.h"
#include "python/src/indexing.h"

bool is_none_slice(const nb::slice& in_slice) {
return (
Expand All @@ -22,12 +23,8 @@ bool is_index_scalar(const nb::object& obj) {
if (!PyIndex_Check(obj.ptr())) {
return false;
}
// Exclude multi-dimensional arrays (mx.array, np.ndarray) by checking ndim
if (nb::hasattr(obj, "ndim")) {
auto ndim = nb::getattr(obj, "ndim");
if (nb::isinstance<nb::int_>(ndim) && nb::cast<int>(ndim) > 0) {
return false;
}
if (nb::ndarray_check(obj) && nb::cast<nb::ndarray<nb::ro>>(obj).ndim() > 0) {
return false;
}
return true;
}
Expand Down
Loading