Skip to content

fix: fail build when Metal compiler header resolution fails #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dogukanveziroglu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fail build when Metal compiler header resolution fails #3332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions mlx/backend/metal/make_compiled_preamble.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ mkdir -p "$OUTPUT_DIR"
CCC="xcrun -sdk macosx metal -x metal"
HDRS=$( $CCC -I"$SRC_DIR" -I"$JIT_INCLUDES" -DMLX_METAL_JIT -E -P -CC -C -H "$INPUT_FILE" $CFLAGS -w 2>&1 1>/dev/null )

# Fail early if the Metal compiler returned errors instead of header paths.
# Valid lines start with '.' chars (depth indicators); anything else means
# xcrun/metal failed (e.g. missing SDK, misconfigured toolchain).
if [ -n "$HDRS" ]; then
invalid_lines=$(echo "$HDRS" | grep -v '^\.*\.' || true)
if [ -n "$invalid_lines" ]; then
echo "Error: Metal compiler header resolution failed for ${INPUT_FILE}" >&2
echo "Expected lines starting with '.' but got:" >&2
echo "$invalid_lines" >&2
echo "" >&2
echo "This usually means xcrun or the Metal toolchain is not configured correctly." >&2
echo "Try running: xcrun -sdk macosx metal --version" >&2
exit 1
fi
fi

# Remove any included system frameworks (for MetalPerformancePrimitive headers)
HDRS=$(echo "$HDRS" | grep -v "Xcode")

Expand Down
Loading