Rename databricks.py to databricks_notebook.py#59
Merged
sunishsheth2009 merged 1 commit intomlflow:mainfrom Feb 18, 2025
Merged
Rename databricks.py to databricks_notebook.py#59sunishsheth2009 merged 1 commit intomlflow:mainfrom
sunishsheth2009 merged 1 commit intomlflow:mainfrom
Conversation
sunishsheth2009
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, running the driver notebook
classification/notebooks/jupyter.ipynbleads to various errors because thedatabricksnamespace mistakenly resolves toclassification/notebooks/databricks.py, a module in the same directory.In contrast, the regression template avoids this issue by naming the Databricks driver notebook
databricks_notebook.py:Solution
A simple way to fix this would be to rename
classification/notebooks/databricks.pytoclassification/notebooks/databricks_notebook.pywhile keeping its content unchanged.