Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mark,
I created onnx models from the 3 tensorflow models you provided. Onnx is open-source format that acts like a "universal translator" for AI models, allowing them to be trained in one framework (like PyTorch or TensorFlow) and be used in a variety of software and hardware.
I validated that these new onnx models have the same outputs as the original tensorflow models. For example the total difference between the model score across an entire dataset was
Using onnx will make your models accessible to more people since they won't have to have tensorflow installed to run them. They only need
onnxruntime.If you'd like I can submit a new version of the
image_filter.pyscript that can be used to run the onnx models. I can call it something likeimage_filter_onnx.py, so both scripts are available to users.