Pass predict additional args to the predict function#157
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing additional arguments to custom predict methods in fitted luz modules. Previously, the ... parameter was documented as unused but is now utilized to forward arguments to custom predict functions.
Key changes:
- Modified
predict.luz_module_fittedto extract and forward additional arguments (excludingstack) to the predict function - Added a new test to verify that additional arguments are correctly passed to custom predict methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| R/module.R | Updated predict logic to extract the stack parameter separately and forward remaining arguments via do.call |
| tests/testthat/test-module.R | Added test case verifying custom predict methods can receive additional arguments like scale |
Comments suppressed due to low confidence (1)
R/module.R:377
- The documentation states that
...is 'Currently unused', but the implementation now uses these parameters to pass additional arguments to custom predict methods. Update the documentation to describe that additional parameters can be passed to custom predict methods.
#' @param ... Currently unused.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.