Open
Conversation
- Update torch_version to 2.8.0 - Fix Linux libtorch URL format (no longer has cxx11-abi in filename) - Add Declarations-2.8.0.yaml generated from PyTorch v2.8.0 - Update torchgen default version to 2.8.0 New functions in 2.8.0: - _fused_rms_norm - _weight_int4pack_mm_with_scales_and_zeros - _grouped_mm Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Bump TORCH_VERSION to 2.8.0 - Update Linux URL format (no cxx11-abi in 2.8.0 filenames) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Thanks @TroyHernandez ! We'll also need to update the lantern headers in https://github.com/mlverse/torch/tree/main/src/lantern/headers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cxx11-abifrom filenames)Why 2.8.0?
PyTorch 2.8 introduced the stable libtorch ABI, which means code compiled against 2.8 can link with 2.9, 2.10, etc. without recompiling. This is a good foundation for future upgrades.
API Changes
No breaking changes. Only 3 new functions added:
_fused_rms_norm_weight_int4pack_mm_with_scales_and_zeros_grouped_mmTesting
Built and tested locally on Ubuntu 24.04 with CUDA 12.8. Basic tensor operations and matmul chains work correctly.
Notes
This PR includes the code changes but lantern binaries would need to be rebuilt against libtorch 2.8.0 and uploaded to the CDN.
Happy to help with any adjustments needed.
🤖 Generated with Claude Code