Skip to content

Refactor voc_classes for consistency#287

Open
sau1812 wants to merge 3 commits intomlverse:mainfrom
sau1812:refactor-voc-classes
Open

Refactor voc_classes for consistency#287
sau1812 wants to merge 3 commits intomlverse:mainfrom
sau1812:refactor-voc-classes

Conversation

@sau1812
Copy link

@sau1812 sau1812 commented Feb 4, 2026

Closes #286

@cregouby
Copy link
Collaborator

cregouby commented Feb 4, 2026

Hello @sau1812,

Thanks a lot for this contribution !

Unfortunately, those changes have to be made on top of two recent / in-the-making addition to the repo. Sorry for that, I should have been more explicit in the issue.
So would you be kind to wait a bit (for the #280 and # 284) to be merged before reviewing your change proposal ?

Sorry for this and thanks for your patience and involvement !

@sau1812
Copy link
Author

sau1812 commented Feb 4, 2026

Hi @cregouby, thank you for the feedback! I understand completely. I will wait for #280 and #284 to be merged first. Once they are in, I'll update my branch and handle any conflicts. Happy to help!

@cregouby
Copy link
Collaborator

cregouby commented Feb 4, 2026

Hello @sau1812,

The code baseline is now ready for you to proceed.

Happy coding !

@sau1812
Copy link
Author

sau1812 commented Feb 4, 2026

Hi @cregouby,

I have updated the PR by syncing with the latest main branch:

Conflict Resolution: Manually resolved conflicts in R/models-deeplabv3.R.

Consistency: Successfully renamed voc_classes to pascal_voc_classes throughout the file to match the new project baseline.

Thank you for your patience, ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

voc_classes() need refactor

2 participants