Fix incorrect dimension handling for grayscale images in base_loader()#290
Open
Chandraveersingh1717 wants to merge 1 commit intomlverse:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #289
Changes
R/folder-dataset.Rwhere grayscale images with singleton first dimension were incorrectly transformedabind(img, img, img, along = 1) %>% aperm(c(3,1,2))toabind(img[1,,], img[1,,], img[1,,], along = 3)Why
The previous code stacked along dimension 1 creating
(3, H, W), then permuted to(W, 3, H)which is incorrect.The fix directly stacks the 2D image along dimension 3 to create
(H, W, 3), which is the expected format.Testing