Bugfixes

[carwash]

This PR addresses syntax errors and missing puzzle constraints that cause the programs to fail in various ways.

Changes in summary:

• Added additional problems present at https://ypologist.com/mmalita17/HOMEPAGE/logic/ but missing from the repo:
  • knight.pro
  • phone.pro
  • queen2.pro
  • river.pro
  • seating.pro
  • secretNumber.pro
  • soccer.pro
• Silenced warnings of singleton variables by declaring them with _;
• Replaced all instances of not/1 (deprecated) with \+/1 or \=/2;
• Replaced all instances of assert/1 (deprecated) with assertz/1;
• Replaced all instances of name/2 (deprecated) with atom_codes/2;
• Replaced all instances of sumlist/2 (deprecated) with sum_list/2;
• aa6.pro: Removed dangling close-bracket (syntax error);
• anagram.pro: Appended false/0 to ensure all solutions are found;
• buffalo.pro:
  • Added write_list/1 (called but not defined);
  • Added missing clauses for the puzzle's fourth restriction;
• costume.pro:
  • Added before/3 (called but not defined);
  • Removed duplicate instance of 'sue' in girl/1 and added 'tess' per the puzzle description;
  • Normalised singleton variables for girls and boys;
• flashlight2.pro: Applied msort/2 to normalise order for list comparisons so that flashlight2.pro and flashlight.pro both find the same two solutions;
• gradepuzzle.pro: Renamed predicate best/2 (not defined) to first/2;
• jazz.pro: Added missing clauses for the puzzle's final restriction;
• jobs1.pro:
  • Singleton variable Son_F corrected to Son_S;
  • Spelling of 'tailor'/'taylor' normalised to 'tailor';
  • Asserted is_set/1 for both fathers and sons as an unstated premise of the puzzle;
  • Nonetheless, the puzzle is still ambiguous, and four alternative solutions are produced.
• knight.pro: Initialised Path to the empty list rather than the start node to avoid unnecessary duplication;
• queen2.pro: Added missing predicate colon (syntax error);
• secretNumber.pro: Removed write/1 since the toplevel prints the solution anyway;
• sudoku.pro:
  • Removed superfluous instances of write_square/1;
  • Applied constraints consistently over all rows;
• sudokuSolver.pro:
  • Removed superfluous instances of write_square/1;
  • Corrected different/2 to work as described and properly account for ungrounded variables;
  • Applied good/2 and different/2 constraints consistently for all rows;
  • This is still an extremely slow sudoku solver which essentially brute-forces the puzzle. Difficult to recommend even for pedagogical purposes.
• writer.pro: Added constraints present in the puzzle description but missing from the code; nonetheless, the puzzle is still ambiguous, and multiple alternative solutions are produced.
• zebra.pro: Corrected the the green house to be to the right of the white house, not merely near it (produced multiple solutions);

I've been using these puzzles to help me teach myself Prolog – thank you so much for sharing them online! They've been extremely useful. I didn't initially intend to fix – or even find! – any bugs, just to read and learn from the code. But over time, working out why the code sometimes didn't work and how to fix it became even more instructive. This PR is submitted in a constructive spirit of appreciation, not as criticism.
This PR includes only bugfixes, but otherwise leaves the files as they are. I have other branches at https://github.com/carwash/PrologPuzzles which incorporate changes in code formatting/style and consistency, as well as adding your logic puzzle solving library bibmm.pro. These are not included with this PR, as formatting is a matter of taste. But if you'd also like to incorporate those changes in a separate PR, let me know.
Thanks again for providing this useful resource!
/Marcus