Fix for plot_map and informative error message in calc_haplotypes#11
Merged
mmollina merged 2 commits intommollina:mainfrom Jun 12, 2025
Merged
Fix for plot_map and informative error message in calc_haplotypes#11mmollina merged 2 commits intommollina:mainfrom
mmollina merged 2 commits intommollina:mainfrom
Conversation
added 2 commits
June 11, 2025 15:31
…d fix for calc_haplotypes which was not giving an informative error message
…d fix for calc_haplotypes which was not giving an informative error message
Owner
|
Hi Eduardo, Thanks again for the pull request and for catching those issues. As I mentioned in the issue thread, I’ve created the Also, I'm planning to implement the get_haplotypes() function soon. thanks @covaruber for the great suggestion! Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Marcelo, thanks for the excellent package. While testing the package I noticed a bug for the plot_map() function and the calc_haplotypes() function.
The first one was failing in the assert_that statements because it was mapping to the type argument instead of the parent argument so I made that change.
For the second one I found that the calc_haplotypes() function was not running for me because I didn't run the mapping function for "p1p2" but there was no informative message since I thought that running the mapping() function for "p1" and "p2" was enough. I included an informative message that I hope will help users identify the same issue I faced.
Cheers,
Eduardo