Skip to content

Fix for plot_map and informative error message in calc_haplotypes#11

Merged
mmollina merged 2 commits intommollina:mainfrom
covaruber:main
Jun 12, 2025
Merged

Fix for plot_map and informative error message in calc_haplotypes#11
mmollina merged 2 commits intommollina:mainfrom
covaruber:main

Conversation

@covaruber
Copy link
Copy Markdown

Dear Marcelo, thanks for the excellent package. While testing the package I noticed a bug for the plot_map() function and the calc_haplotypes() function.

The first one was failing in the assert_that statements because it was mapping to the type argument instead of the parent argument so I made that change.

For the second one I found that the calc_haplotypes() function was not running for me because I didn't run the mapping function for "p1p2" but there was no informative message since I thought that running the mapping() function for "p1" and "p2" was enough. I included an informative message that I hope will help users identify the same issue I faced.

Cheers,
Eduardo

Giovanny Covarrubias added 2 commits June 11, 2025 15:31
…d fix for calc_haplotypes which was not giving an informative error message
…d fix for calc_haplotypes which was not giving an informative error message
@mmollina
Copy link
Copy Markdown
Owner

Hi Eduardo,

Thanks again for the pull request and for catching those issues.

As I mentioned in the issue thread, I’ve created the 2025_updates branch to integrate new features based on user feedback. I’ll go ahead and merge your changes into the main branch and pull them into 2025_updates.

Also, I'm planning to implement the get_haplotypes() function soon. thanks @covaruber for the great suggestion!

Best,
Marcelo

@mmollina mmollina merged commit bdea3ce into mmollina:main Jun 12, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants