Fix signedness error of max LOS size in C2#347
Closed
wks wants to merge 1 commit intommtk:jdk-11from
Closed
Conversation
The `PlanConstraints::max_non_los_default_alloc_bytes` constant is a `usize` and can be `usize::MAX` for some plans including NoGC. The C2 code erroneously considered it signed and did signed comparison against object sizes. Consequently, when allocating dynamically sized arrays, the C2-generated code always goes to the slow path. It slows down certain workloads (such as hsqldb and luindex in DaCapo 2006) by 20% in total time. We fix this bug by always performing 64-bit unsigned comparison.
Contributor
Author
|
Several DaCapo tests failed during "Fetch dacapo-23.9-RC3-chopin cache". It looks like some transient network error. |
Contributor
Author
|
We have used Mergify to backport the PR for jdk-21 to jdk-11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PlanConstraints::max_non_los_default_alloc_bytesconstant is ausizeand can beusize::MAXfor some plans including NoGC. The C2 code erroneously considered it signed and did signed comparison against object sizes. Consequently, when allocating dynamically sized arrays, the C2-generated code always goes to the slow path. It slows down certain workloads (such as hsqldb and luindex in DaCapo 2006) by 20% in total time.We fix this bug by always performing 64-bit unsigned comparison.