Skip to content

Improve pgo-build.sh#351

Merged
qinsoon merged 1 commit intommtk:jdk-21from
qinsoon:improve-pgo-build-script
Mar 26, 2026
Merged

Improve pgo-build.sh#351
qinsoon merged 1 commit intommtk:jdk-21from
qinsoon:improve-pgo-build-script

Conversation

@qinsoon
Copy link
Copy Markdown
Member

@qinsoon qinsoon commented Mar 26, 2026

  1. Reduce hard-coded path/version/etc, making it easier to maintain and use in both jdk11 and jdk21.
  2. Add a step to configure jdk, so the script now works on fresh cloned repos.

@qinsoon qinsoon requested a review from wks March 26, 2026 00:54
Copy link
Copy Markdown
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 4037ffa into mmtk:jdk-21 Mar 26, 2026
107 of 111 checks passed
mergify Bot pushed a commit that referenced this pull request Mar 26, 2026
1. Reduce hard-coded path/version/etc, making it easier to maintain and
use in both jdk11 and jdk21.
2. Add a step to configure jdk, so the script now works on fresh cloned
repos.

(cherry picked from commit 4037ffa)

# Conflicts:
#	.github/scripts/pgo-build.sh
qinsoon added a commit that referenced this pull request Mar 26, 2026
1. Reduce hard-coded path/version/etc, making it easier to maintain and
use in both jdk11 and jdk21.
2. Add a step to configure jdk, so the script now works on fresh cloned
repos.<hr>This is an automatic backport of pull request #351 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: Yi Lin <qinsoon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants