Conversation
danielzgtg
left a comment
There was a problem hiding this comment.
I reproduced the .string() problem, thank you for fixing our oversight of tts-server!
I made two minor suggestions for improvement.
|
@mmwillet Pinging as this will use your CI minutes. I plan to merge after 24 hours, despite the Windows runner being projected to more than triple the minutes used, because we weren't using many CI minutes to begin with. |
|
I do have Windows VMs, I might be able to test it out. @mrexodia, are you using msvc or mingw? Edit: Whoops probably should read the code first. |
|
I am using MSVC. If you want to test you can use a zig toolchain: https://github.com/mrexodia/zig-cross |
ecyht2
left a comment
There was a problem hiding this comment.
Can you also update the README.md to show that we have Windows support?
I do not know what to change in the feature matrix because I did not test everything. I think this should be done by one of the maintainers and not a random contributing some minor compilation fixes 😅 |
|
I also fixed the Linux build, tested locally with Ubuntu 24.04 LTS |
Co-authored-by: ecyht2 <94816144+ecyht2@users.noreply.github.com>
std::numbers::piinstead of non-standardM_PIto fixdummybuildpath.string()where needed to fix compilation