adds padding, output padding, and depthwise cpu support with tests#3
Open
adds padding, output padding, and depthwise cpu support with tests#3
Conversation
mmwillet
commented
Jun 26, 2025
Comment on lines
+4024
to
+4026
| // This does not represent a real limitation in convolutional transposition. Rather, for simplicity the | ||
| // implementation currently assumes that padding is never greater than stride. | ||
| GGML_ASSERT(p0 < s0); |
Owner
Author
There was a problem hiding this comment.
I probably should work to completely remove this constraint.
mmwillet
commented
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per mmwillet/TTS.cpp#66, this PR cleans up and adds the TTS.cpp patches to 1d convolutional transposition in order to be upstreamed to GGML main with the underlying goal of aligning modern GGML with TTS.cpp requirements.