feat: support application/octet-stream req/res bodies #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnahkies
commented
Aug 9, 2025
| @@ -10875,7 +10875,7 @@ export class StripeApiService { | |||
| | Server<"getQuotesQuotePdf_StripeApiService"> | |||
| | string = StripeApiServiceServers.operations.getQuotesQuotePdf().build(), | |||
| ): Observable< | |||
| | (HttpResponse<string> & {status: 200}) | |||
| | (HttpResponse<Blob> & {status: 200}) | |||
There was a problem hiding this comment.
TODO: add responseType: "blob" to the HttpClient call
mnahkies
commented
Aug 9, 2025
| @@ -134,7 +136,7 @@ router.${builder.method.toLowerCase()}(\`${builder.route}\`, async (req: Request | |||
| const input = { | |||
| params: ${params.path.schema ? `parseRequestInput(${symbols.paramSchema}, req.params, RequestInputType.RouteParam)` : "undefined"}, | |||
| query: ${params.query.schema ? `parseRequestInput(${symbols.querySchema}, req.query, RequestInputType.QueryString)` : "undefined"}, | |||
| body: ${params.body.schema ? `parseRequestInput(${symbols.requestBodySchema}, req.body, RequestInputType.RequestBody)` : "undefined"}, | |||
| body: ${params.body.schema ? (params.body.contentType === "application/octet-stream" ? `parseRequestInput(${symbols.requestBodySchema}, await parseOctetStream(req), RequestInputType.RequestBody)` : `parseRequestInput(${symbols.requestBodySchema}, req.body, RequestInputType.RequestBody)`) : "undefined"}, | |||
There was a problem hiding this comment.
TODO: this is getting a bit out of hand
mnahkies
commented
Aug 9, 2025
| // TODO: support more serializations | ||
| // | "Blob" |
There was a problem hiding this comment.
TODO: update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
application/octet-streamcontent types for both request and response bodiesraw-bodyfor the request body parsing side of things. It might make sense to see if we could always use this and drop the other body parsers