[ENH] MNEScan FTBuffer plugin - Channel names compatibility#840
Open
juangpc wants to merge 11 commits intomne-tools:mainfrom
Open
[ENH] MNEScan FTBuffer plugin - Channel names compatibility#840juangpc wants to merge 11 commits intomne-tools:mainfrom
juangpc wants to merge 11 commits intomne-tools:mainfrom
Conversation
Collaborator
Author
|
Ready for review. 😟 |
Codecov Report
@@ Coverage Diff @@
## main #840 +/- ##
==========================================
- Coverage 21.80% 21.78% -0.03%
==========================================
Files 451 451
Lines 39087 39077 -10
==========================================
- Hits 8522 8512 -10
Misses 30565 30565
|
juangpc
changed the title
juangpc
changed the title
juangpc
force-pushed
the
channel_names
branch
from
c26e7bf to
d205647
Compare
Collaborator
|
I'm not sure what happened but there are a bunch of old commits added again in this pr |
juangpc
force-pushed
the
channel_names
branch
from
bb739d0 to
aba68a9
Compare
Collaborator
Author
|
Should be fixed now. |
Collaborator
Author
|
@LorenzE @gabrielbmotta Please review this when you can. |
LorenzE
reviewed
Nov 3, 2021
| data.info.meas_date[1] = 0; | ||
| } | ||
|
|
||
| if ( data.info.sfreq <= 0 ) |
Member
There was a problem hiding this comment.
as long as we have not set on a specific formatting rule, I would propose follow the old style aka no spaces before and after (as well as )
LorenzE
reviewed
Nov 3, 2021
LorenzE
reviewed
Nov 3, 2021
| // fiff_int_t machid[2]; /**< Unique machine ID. */ | ||
| // fiffTimeRec time; /**< Time of the ID creation. */ | ||
| //} fiffIdRec,*fiffId; /**< This is the file identifier. */ | ||
| //typedef fiffIdRec fiff_id_t; |
Member
There was a problem hiding this comment.
I always found having these MNE C structs very useful from time to time. Any reason why you want to delete them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.