Add walk as default value for first and last legs in PublicTransportMode#245
Open
Mind-the-Cap wants to merge 5 commits intomainfrom
Open
Add walk as default value for first and last legs in PublicTransportMode#245Mind-the-Cap wants to merge 5 commits intomainfrom
Mind-the-Cap wants to merge 5 commits intomainfrom
Conversation
Add walk as default value for first and last legs in PublicTransportMode: it will be easier for users
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 70.42% 70.42%
=======================================
Files 56 56
Lines 2424 2424
=======================================
Hits 1707 1707
Misses 717 717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I see one potential problem : the parameters of the default WalkMode used in the PublicTransportMode will be different from the parameters used by the user configured "single mode" WalkMode. Having different parameters could be a good idea to differentiate "single mode" walking from "multimodal" walking, but hiding this in defaults seems risky ? The old behavior is : which is not equivalent to the new behavior : Because the walk_pt will now use default parameters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add walk as default value for first and last legs in PublicTransportMode, as it will be easier for users