[game] Initialize skill icons for context actions#103
Merged
modawan merged 1 commit intomodawan:masterfrom Apr 27, 2026
Merged
Conversation
modawan
approved these changes
Apr 27, 2026
Owner
modawan
left a comment
There was a problem hiding this comment.
Good catch! We had similar problems with spells and feats, so we should really check that all services are initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initializes the skills service during game module setup so skill-backed context actions can resolve their icons.
This fixes missing/invisible icons for context actions such as Security while preserving the existing action eligibility rules.
Testing
engineandlauncherinRelWithDebInfoon Windowsgit diff --check upstream/master...HEADsrc/libs/game/di/module.cppManual verification