Skip to content

[game] Initialize skill icons for context actions#103

Merged
modawan merged 1 commit intomodawan:masterfrom
Eldbury:fix/security-context-icons
Apr 27, 2026
Merged

[game] Initialize skill icons for context actions#103
modawan merged 1 commit intomodawan:masterfrom
Eldbury:fix/security-context-icons

Conversation

@Eldbury
Copy link
Copy Markdown

@Eldbury Eldbury commented Apr 26, 2026

Summary

Initializes the skills service during game module setup so skill-backed context actions can resolve their icons.

This fixes missing/invisible icons for context actions such as Security while preserving the existing action eligibility rules.

Testing

  • Built engine and launcher in RelWithDebInfo on Windows
  • Ran git diff --check upstream/master...HEAD
  • Verified branch diff only includes:
    • src/libs/game/di/module.cpp

Manual verification

  • K1 Endar Spire: Trask's Security context action appears with a visible icon
  • K1 Dantooine: Security icon appears only for party members with Security
  • Unlocked doors still show normal interaction, not Security

Copy link
Copy Markdown
Owner

@modawan modawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We had similar problems with spells and feats, so we should really check that all services are initialized.

@modawan modawan merged commit 9ac4fb7 into modawan:master Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants