Conversation
modawan
changed the title
If SDL3 is not available on the system, it can be built from source with -DCMAKE_INSTALL_PREFIX=/path/to/sdl/install Reone CMake can use it with -DCMAKE_PREFIX_PATH=/path/to/sdlinstall The patch adds SDL3_LDFLAGS to provide search paths to the linker.
This targets OpenGL Core 4.0 with a minimal set of extensions. GL_EXT_texture_compression_s3tc and GL_EXT_texture_filter_anisotropic are the only required ones.
Additionally I improved the error reporting if context creation fails. This should avoid any weirdness that GLEW brings on some platforms and is generally more maintained.
The game ignores some events such as SDL_TEXTINPUT, but we need to register them in ImGui. This fixes all text input widgets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patchset adds Dear ImGui library as a dependency, and integrates it with the engine. This can be a basis for tools to assist development, such as a 2DA editor, a model viewer, object inspection, etc.
New
Editorclass has a full access toEngine, and therefore can access any subsystem in the game, and change it at run-time. No support for writing changes back to game files yet, but this can be added later.Press F1 to toggle Editor window in game. So far there is only a demo, and stubs for a 2DA editor.
This design is not finalized. It can be changed, or scrapped completely if we find a better way. Feel free to comment here on Discord. This PR is going to stay open for now.