Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #552
The god controller's inventory will now be preserved when you switch in and out of it, as requested, by saving its contents in storage. I've set it up in a way that can accommodate multiple players, even though god mode is only meant for use in single player or by an admin. Just in case.
Also, I've added a check that will make it so the God Mode button will always be there if you start the game in god mode (meaning, in Sandbox mode). It would be understandably frustrating if someone were to start a game intending to jump in and out of God Mode, only to realize several hours in that they forgot to enable the setting.
Addresses #554
Adds checks to create_character function to ensure that any items you try to add or remove from an inventory exist.
I would also like to address #466 here by removing the Editor Mode button, since it's basically pointless. /editor fulfills the same function, and without any of the obtuse issues. But I need @KiwiHawk to give the go ahead for that.
I have been unable to recreate the crash described in #539.