[codex] Refactor skills workspace scroll ownership#15
Merged
SI-RUI-ZHANG merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
SI-RUI-ZHANG
added a commit
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the Skills workspace so scroll ownership is explicit and singular.
window.scrollYRoot Cause
The list scroller already existed, but the outer Skills route shell still allowed document-level overflow. On narrower widths, the workspace also had a separate breakpoint path that intentionally switched back to page scroll. That left two competing scroll models and allowed the whole pane to move instead of keeping header/search chrome fixed.
Validation
bash scripts/ci_validate.shnpm testnpm run test:e2eImpact
The Skills page now behaves consistently across both tabs and across widths: header/search chrome stays fixed within the workspace and the cards list owns scrolling.