Update: fix managed skill source folder links#17
Merged
SI-RUI-ZHANG merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
SI-RUI-ZHANG
added a commit
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原问题
Managed skill source links were still derived from the install locator with the old
/tree/HEAD/<skill-id>compatibility rule, so nested repo layouts such asvercel-labs/agent-browsercould resolve to a close-but-wrong folder URL.本次修复
Persist the exact fetched GitHub ref/path into the shared-store manifest, build managed skill source links from that exact metadata, and keep a one-time exact-resolution fallback only for legacy manifest entries that predate the new fields.
改动文件
skill_manager/application/marketplace/catalog.py
skill_manager/application/marketplace/resolver.py
skill_manager/application/skills/inventory.py
skill_manager/application/skills/mutations.py
skill_manager/application/skills/queries.py
skill_manager/application/source_fetch_service.py
skill_manager/domain/observations.py
skill_manager/sources/init.py
skill_manager/sources/github.py
skill_manager/store/manifest.py
skill_manager/store/shared_store.py
tests/integration/test_marketplace_api.py
tests/support/marketplace_fixture.py
tests/unit/test_application_service.py
tests/unit/test_manifest.py
tests/unit/test_marketplace_service.py
tests/unit/test_sources.py
tests/unit/test_store.py
Reviewer: @SI-RUI-ZHANG