Update: gate package-smoke CI jobs to release branches#19
Merged
SI-RUI-ZHANG merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
The macOS package-smoke-arm64 and package-smoke-x64 jobs perform a full PyInstaller build + tarball + npm/homebrew validation roundtrip on every PR and every main push. They run for 1.5-3.5 minutes on top of the macos-* runner queue time, despite being redundant with the Release workflow for normal code changes. Gate them behind 'release/**' branches + workflow_dispatch so: - PR CI: only backend-compat + frontend-validate (~41s) - Push to main CI: same, no package-smoke - Push to release/* branches: full CI including package-smoke - Manual trigger: full CI via workflow_dispatch This cuts typical PR CI wall time from ~4m30s to under 1 minute while keeping release-gate signal intact.
SI-RUI-ZHANG
added a commit
that referenced
this pull request
Apr 19, 2026
The macOS package-smoke-arm64 and package-smoke-x64 jobs perform a full PyInstaller build + tarball + npm/homebrew validation roundtrip on every PR and every main push. They run for 1.5-3.5 minutes on top of the macos-* runner queue time, despite being redundant with the Release workflow for normal code changes. Gate them behind 'release/**' branches + workflow_dispatch so: - PR CI: only backend-compat + frontend-validate (~41s) - Push to main CI: same, no package-smoke - Push to release/* branches: full CI including package-smoke - Manual trigger: full CI via workflow_dispatch This cuts typical PR CI wall time from ~4m30s to under 1 minute while keeping release-gate signal intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原问题
CI里的package-smoke-arm64与package-smoke-x64每次 PR 和 main 推送都会跑：安装依赖 → PyInstaller 打包 → 生成 tarball → 计算 SHA256 → 验证 npm wrapper + Homebrew formula，单次约 1m25s / 3m33s，外加macos-*runner 的队列时间。对于普通代码改动，这些跑跟后续Releaseworkflow 在 tag 上跑完全重叠，是冗余信号。本次修复
package-smoke-arm64/x64加if: startsWith(github.ref, 'refs/heads/release/') || github.event_name == 'workflow_dispatch'。on.push.branches补上release/**，新增workflow_dispatch。行为变化：
release cut / 验证场景仍然有 package-smoke 覆盖，日常 PR 不再被 macos 队列拖慢。
改动文件
.github/workflows/ci.yml
Reviewer: @SI-RUI-ZHANG