Tweak how McpClientTool.InvokeAsync exposes some content #941
+419
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced `InvokeCoreAsync` in `McpClientTool.cs` to handle non-text content by converting it to `AIContent` when possible. This enables richer content handling for downstream `IChatClients` while maintaining fallback serialization for unsupported cases.
|
Ah, this looks great for IChatClients with media tool result support. The tests made me think that ResourceLinks could be handled similar to how vs code does. Afaik it resolves those in a way where the message history retains that it's a link, and then it fetches the resource from the mcp server when needed, ie after tool call and on reconnect/resume. It's tangential to this PR I know, but having a resource link AIContent with an McpClient reference and dynamic resolution would replicate this I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
InvokeCoreAsyncinMcpClientTool.csto handle non-text content by converting it toAIContentwhen possible. This enables richer content handling for downstreamIChatClientswhile maintaining fallback serialization for unsupported cases.