Skip to content

Do not raise discard McpError when got unrecognized SSE event type #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ else if (MESSAGE_EVENT_TYPE.equals(event.event())) {
}
}
else {
s.error(new McpError("Received unrecognized SSE event type: " + event.event()));
logger.warn("Received unrecognized SSE event type: {}", event.event());
}
}).transform(handler)).subscribe();

Expand Down Expand Up @@ -315,9 +315,9 @@ protected Flux<ServerSentEvent<String>> eventStream() {// @formatter:off
public Mono<Void> closeGracefully() { // @formatter:off
return Mono.fromRunnable(() -> {
isClosing = true;

// Dispose of subscriptions

if (inboundSubscription != null) {
inboundSubscription.dispose();
}
Expand Down