Add _meta Field #129
Open
Add _meta Field #129
+162
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaipiyann
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
CodeWithKyrian
requested changes
Nov 1, 2025
| public function __construct( | ||
| public ?string $name = null, | ||
| public ?string $description = null, | ||
| public ?array $_meta = null |
There was a problem hiding this comment.
You could name the PHP variables $meta instead to stay consistent with how meta is handled in the Request class, and then when serializing to and from array, use the _meta key where neccesary
There was a problem hiding this comment.
Yes I could have but :
- it seems to me it was inconsistent before cause ListRootsResult and InitializeResult are using _meta
- I thought it was easier to be consistent with the naming of the shema
- And now there is a lot more _meta than meta ;-)
I hope you don't mind
There was a problem hiding this comment.
I agree with @CodeWithKyrian here, so let's fix that with #134
src/Schema/ResourceTemplate.php
Outdated
| mimeType: $data['mimeType'] ?? null, | ||
| annotations: isset($data['annotations']) ? Annotations::fromArray($data['annotations']) : null | ||
| annotations: isset($data['annotations']) ? Annotations::fromArray($data['annotations']) : null, | ||
| _meta: isset($data['_meta']) ? (int) $data['_meta'] : null |
There was a problem hiding this comment.
Same int cast issue here
|
And this time I did run all the tests also so it should pass the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add _meta field to schema
Motivation and Context
Field meta from the spec is missing
https://modelcontextprotocol.io/specification/2025-06-18/basic#meta
How Has This Been Tested?
Tested with MCP Inspector
Breaking Changes
No
Types of changes
Checklist