Skip to content

feat: implement OPTIONS request support for Preflight checks in StreamableHTTP #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: implement OPTIONS request support for Preflight checks in StreamableHTTP #1245

wants to merge 3 commits into from
+13 −0

Conversation

TheRealSeber
Copy link

Motivation and Context

Fixes: (#1079)

How Has This Been Tested?

Locally

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

@TheRealSeber TheRealSeber requested a review from a team as a code owner August 7, 2025 02:35
@TheRealSeber TheRealSeber requested a review from ihrpr August 7, 2025 02:35
@TheRealSeber TheRealSeber changed the title feat: implement OPTIONS request support for Preflight checks feat: implement OPTIONS request support for Preflight checks in StreamableHTTP Aug 7, 2025
domdomegg
domdomegg approved these changes Aug 9, 2025
View reviewed changes
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would appreciate @ihrpr or @maxisbey sanity checking though

@Kludex
Copy link
Member

Kludex commented Aug 9, 2025 •
edited
Loading

This shouldn't go in like this.

Similar to #1201.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domdomegg domdomegg domdomegg approved these changes

@ihrpr ihrpr Awaiting requested review from ihrpr ihrpr is a code owner automatically assigned from modelcontextprotocol/python-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheRealSeber @Kludex @domdomegg