Skip to content

fix: Catch http errors #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Catch http errors #1308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/mcp/client/streamable_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,17 +400,22 @@ async def post_writer(
sse_read_timeout=self.sse_read_timeout,
)

async def handle_request_async():
if is_resumption:
await self._handle_resumption_request(ctx)
else:
await self._handle_post_request(ctx)
async def handle_request_async(ctx: RequestContext, is_resumption: bool) -> None:
try:
if is_resumption:
await self._handle_resumption_request(ctx)
else:
await self._handle_post_request(ctx)
except Exception as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too broad of an error, we should be more specific about the type of Exception we handle here.

We should at least limit to HTTPStatusError if your problem is with HTTP errors specifically.

# Send error to read stream so client knows request failed
logger.error("Request handler error: %s", e)
await ctx.read_stream_writer.send(e)

# If this is a request, start a new task to handle it
if isinstance(message.root, JSONRPCRequest):
tg.start_soon(handle_request_async)
tg.start_soon(handle_request_async, ctx, is_resumption)
else:
await handle_request_async()
await handle_request_async(ctx, is_resumption)

except Exception:
logger.exception("Error in post_writer")
Expand Down
Loading