fix: wrapped annotations handling in func_metadata #1392
+62
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
maxisbey
requested changes
Oct 3, 2025
There was a problem hiding this comment.
Instead of any custom forward reference resolving code, just use get_type_hints from https://docs.python.org/3/library/typing.html#typing.get_type_hints
As was done here: https://github.com/modelcontextprotocol/python-sdk/pull/1286/files#diff-4a929a2d33aa16d96d544463138bab06b115bd9653dcdb842d94508c8b30a6cd
maxisbey
added
the
needs more work
|
Thanks @maxisbey will do that. |
stevenh
force-pushed
the
fix/wrapped_annotations
branch
from
66290b6 to
088335d
Compare
Use the original function's __globals__ for type hint resolution when dealing with wrapped functions. This ensures that any type hints defined in the original function's module are correctly resolved. This also includes adding common typing names for resiliency. Fixes modelcontextprotocol#1391
stevenh
force-pushed
the
fix/wrapped_annotations
branch
from
088335d to
57fe5ba
Compare
|
Is this what you had in mind @maxisbey ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the original function's globals for type hint resolution when dealing with wrapped functions. This ensures that any type hints defined in the original function's module are correctly resolved.
This also includes adding common typing names for resiliency.
Fixes #1391
Motivation and Context
Fixes tool handling for wrapped methods that use annotations.
How Has This Been Tested?
Test is included.
Breaking Changes
This should be fully backwards compatible.
Types of changes
Checklist
Additional context
Tries to ensure success even if standard typing types are missing.