fix: Remove unnecessary constructor from ResourceServerSettings #1424
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
ResourceServerSettings
class had a custom__init__
method that simply calledsuper().__init__(**data)
without adding any additional functionality. This is redundant since Pydantic'sBaseSettings
already provides the same behavior by default.The TODO comment from Marcelo indicated uncertainty about whether this constructor was needed. After reviewing the code, it's clear that:
BaseSettings
already handles environment variable loading and validation__init__
method provides no additional valueHow Has This Been Tested?
ResourceServerSettings
still properly loads configuration from environment variablesBreaking Changes
None. This is a purely internal change that removes redundant code without affecting the public API or behavior of the class.
Types of changes
Checklist
Additional context
This change aligns with the principle of "don't repeat yourself" (DRY) and removes code that was flagged as potentially unnecessary by the original author. The
BaseSettings
class from Pydantic already provides all the initialization functionality needed for configuration management.