Improve exception handling for ClientDisconnect errors #1647
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle ClientDisconnect gracefully (return 499, not 500)
Problem
ClientDisconnectexceptions are currently handled incorrectly inStreamableHTTPServerTransport._handle_post_request:ClientDisconnect occurs during normal operations when clients disconnect mid-request due to:
These are client-side events, not server failures, and should not be treated as server errors.
Root Cause
The broad
except Exceptionhandler in_handle_post_requestcatchesClientDisconnectbefore it can be handled appropriately, resulting in incorrect error logging and HTTP status codes.File:
src/mcp/server/streamable_http.py(lines ~490-500)Solution
This PR adds a specific
ClientDisconnectexception handler before the broadExceptionhandler:ClientDisconnectexplicitly