MCP: Icons type as per SEP-973, spec types test improvements, ImplementationSchema use IconsSchema #947
+684
−676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onSchema use IconsSchema
cliffhall
suggested changes
Sep 17, 2025
src/spec.types.test.ts
Outdated
Comment on lines
453
to
455
| it.each(typesToCheck)('%s should have a compatibility test', (type) => { | ||
| expect(sdkTypeChecks[type as keyof typeof sdkTypeChecks]).toBeDefined(); | ||
| }); |
There was a problem hiding this comment.
This should be indented one level. (why don't we have prettier on this repo??? - rhetorical)
There was a problem hiding this comment.
Have ran prettier manually on the file, will commit that once the .strip topic is closed above
There was a problem hiding this comment.
I don't see a resolve conversation button on the strip topic, so I'll dismiss my request. If you can push your prettier changes, will review again.
There was a problem hiding this comment.
This should be indented one level. (why don't we have prettier on this repo??? - rhetorical)
@cliffhall since you mentioned this... #953 😁
src/spec.types.test.ts
Outdated
| const specTypes = extractExportedTypes(fs.readFileSync(SPEC_TYPES_FILE, 'utf-8')); | ||
| const sdkTypes = extractExportedTypes(fs.readFileSync(SDK_TYPES_FILE, 'utf-8')); | ||
| const testSource = fs.readFileSync(__filename, 'utf-8'); | ||
| const typesToCheck = specTypes.filter(type => !MISSING_SDK_TYPES.includes(type)); |
…onstantinov/typescript-sdk into feature/SEP-973-icons-type-spec-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Iconstype support for modelcontextprotocol/modelcontextprotocol#973 (PR), which exposed additional metadata for Implementations, Resources, Tools and Prompts.Motivation and Context
This PR adds the missing
Iconstype and respectiveIconsSchemazod schema.Further, a few improvements have been made to
spec.types.test.ts:How Has This Been Tested?
Tests and type checks are passing, there are no changes to actual implementation.
Breaking Changes
No breaking changes - just adding the Icons type and test improvements.
Types of changes
Checklist
Additional context