Skip to content

Fix incorrect units in icons of to_cm2 and from_cm2 #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect units in icons of to_cm2 and from_cm2 #4294

wants to merge 1 commit into from

Conversation

henrikt-ma
Copy link
Contributor

Addressing user complaint. As far as I can tell, the old placement of the unit text still works fine.

@henrikt-ma henrikt-ma added the L: Blocks Issue addresses Modelica.Blocks label Jan 31, 2024
tobolar
tobolar approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me.

HansOlsson
HansOlsson approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@beutlich beutlich added the icon Issues addresses the icon graphics label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobolar tobolar tobolar approved these changes

@HansOlsson HansOlsson HansOlsson approved these changes

Assignees
No one assigned
Labels
icon Issues addresses the icon graphics L: Blocks Issue addresses Modelica.Blocks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrikt-ma @tobolar @HansOlsson @beutlich