Use nthRoot as proposed for Modelica 3.7. #4392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that there are some other uses that were deliberately not updated here: - Modelica.Fluid.Dissipation.HeatTransfer.General.kc_approxForcedConvection_KC - Modelica.Fluid.Dissipation.HeatTransfer.Channel.kc_evenGapLaminar_KC - Modelica.Fluid.Dissipation.HeatTransfer.HelicalPipe.kc_laminar_KC - Modelica.Fluid.Dissipation.HeatTransfer.Plate.kc_laminar_KC - Modelica.Fluid.Pipes.BaseClasses.HeatTransfer.LocalPipeFlowHeatTransfer - Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung - Modelica.Fluid.Dissipation.Utilities.Functions.PressureLoss.TwoPhase.SlipRatio However, if done it must be after switching to sqrt. I believe Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung should be updated, but I don't know about the rest. However, the units seems to be weird in that one (Ångström?) so I'm not proposing it. Note that many of them use dimensionless numbers and thus there is no unit-issue. There are also other rational exponents, I'm even less sure about them.
HansOlsson
added
L: Fluid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that there are some other uses that were deliberately not updated here:
However, if done it must be after switching to sqrt.
I believe Modelica.Media.IdealGases.Common.MixtureGasNasa.mixtureViscosityChung should be updated, but I don't know about the rest. However, the units seems to be weird in that one (Ångström?) so I'm not proposing it.
Note that many of them use dimensionless numbers and thus there is no unit-issue. There are also other rational exponents, I'm even less sure about them.
Closes #4370