Draft
Conversation
elmir-nahodovic
left a comment
There was a problem hiding this comment.
- In [[combitable1d_example]], what is
x.0referencing? Shouldn't that entry in the example be empty? - I think the link https://doc.modelica.org/om/Modelica.Blocks.Tables.html is outdated, and should at least be replaced by one for Modelica 4.0, https://doc.modelica.org/Modelica%204.0.0/Resources/helpDymola/Modelica_Blocks_Tables.html#Modelica.Blocks.Tables
- (Maybe a general comment on ls-struct) Are the variables with prefix
in_/out_supposed to be added to the FMU by the exporter for each input variable of the tables? Or is it up to the model to contain these variables?- For example in
[[combitable2d_example]], the terminalsAndIcons.xml gives thatin_xis a domain input, but is that variable included in the model that was exported or is it added by the FMU ?
- For example in
- Since this is Modelica focused, it would be good to use a specific model containing combitables
- Like the one provided by TorstenBlochwitz in #18, but in the example section
- It would also be constructive if one combitable example matched example 4.2. 2-d example of a lookup table on a rectilinear grid
- To show the map both with the context of combitables compared to the general context of ls-struct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.