Skip to content

update import #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jintao-Huang merged 1 commit into from
Apr 3, 2026
+1 −1
Merged

update import #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcore_bridge/model/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
from .constant import ModelType
from .gpt_model import GPTModel
from .mm_gpt_model import MultimodalGPTModel
from .register import get_mcore_model, get_mcore_model_type, get_model_meta
from .register import MODEL_MAPPING, get_mcore_model, get_mcore_model_type, get_model_meta
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Exposing the raw MODEL_MAPPING dictionary in the public API allows external code to modify the registry directly, which can bypass the validation logic in register_model and lead to inconsistencies with the internal model_type_mapping cache in register.py. If the intention is to allow external registration of models, it is recommended to export the register_model function instead. If the intention is to allow inspection of the registered models, consider providing a read-only view or a getter function to maintain better encapsulation.

Suggested change
from .register import MODEL_MAPPING, get_mcore_model, get_mcore_model_type, get_model_meta
from .register import get_mcore_model, get_mcore_model_type, get_model_meta, register_model

Loading