Reworked app update flow #3960
Reworked app update flow #3960
Conversation
|
would be good to double check my latest changes didn't break functionality, requested another review from @IMB11 Feel free to queue for merge if it looks good to you |
|
Out of interest, what's blocking this? |
IMB11
force-pushed
the
app-updater-rework
branch
from
e8b95d8 to
a6fc14c
Compare
Signed-off-by: Cal H. <hendersoncal117@gmail.com>
…wnloads if you're on a metered network
# Conflicts: # apps/app-frontend/src/App.vue # apps/app-frontend/src/components/ui/ProgressBar.vue # apps/app-frontend/src/components/ui/modal/ModalWrapper.vue # apps/app-frontend/src/helpers/settings.ts # apps/app-frontend/src/helpers/utils.js # apps/app/package.json # apps/frontend/package.json # apps/frontend/src/components/ui/servers/PlatformMrpackModal.vue # packages/app-lib/Cargo.toml # packages/ui/src/components/modal/NewModal.vue
# Conflicts: # packages/blog/compiled/index.ts
There was a problem hiding this comment.
The backend side looks good to me after all the recent additions, thanks!
As a side note, I think we should simplify the handling of metered connections and their interaction with the automatic update downloads option. Instead of the current approach, we could offer a single setting with three choices: always download, only download over unmetered connections, and always task, as suggested by @Gaming32 when we had a chat over the matter over Slack. Any initial popup would then be limited to let users choose their preferred default, at most. That way, we'd gracefully handle cases where users switch networks, without making them face the unexpected extra costs or missed updates that a more binary approach of either always downloading automatically or never doing it would.
The old app updater automatically installed new updates immediately on startup with no user involvement or consent. This reworks it to have a new modal that asks whether the user would like to update now, update on next restart, or skip this update.
Closes DEV-128
Closes DEV-229