Skip to content

Always enable "advanced" instance creation options #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 28, 2025
Merged

Always enable "advanced" instance creation options #4161

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d0d7e0
Update InstanceCreationModal.vue
ItsFelix5 Aug 12, 2025
5d50728
change checkbox label
Prospector Aug 13, 2025
e973298
remove unused icon
Prospector Aug 13, 2025
c823047
Merge remote-tracking branch 'origin/main' into fork/ItsFelix5/patch-1
Prospector Aug 28, 2025
be49bde
lint
Prospector Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions apps/app-frontend/src/components/ui/InstanceCreationModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,14 @@
open-direction="top"
:show-labels="false"
/>
<Checkbox
v-if="showAdvanced"
v-model="showSnapshots"
class="filter-checkbox"
label="Include snapshots"
/>
<Checkbox v-model="showSnapshots" class="filter-checkbox" label="Show all versions" />
</div>
</div>
<div v-if="showAdvanced && loader !== 'vanilla'" class="input-row">
<div v-if="loader !== 'vanilla'" class="input-row">
<p class="input-label">Loader version</p>
<Chips v-model="loader_version" :items="['stable', 'latest', 'other']" />
</div>
<div v-if="showAdvanced && loader_version === 'other' && loader !== 'vanilla'">
<div v-if="loader_version === 'other' && loader !== 'vanilla'">
<div v-if="game_version" class="input-row">
<p class="input-label">Select version</p>
<multiselect
Expand All @@ -75,10 +70,6 @@
</div>
</div>
<div class="input-group push-right">
<Button @click="toggle_advanced">
<CodeIcon />
{{ showAdvanced ? 'Hide advanced' : 'Show advanced' }}
</Button>
<Button @click="hide()">
<XIcon />
Cancel
Expand Down Expand Up @@ -198,7 +189,6 @@

<script setup>
import {
CodeIcon,
FolderOpenIcon,
FolderSearchIcon,
InfoIcon,
Expand Down Expand Up @@ -236,7 +226,6 @@ const loader_version = ref('stable')
const specified_loader_version = ref('')
const icon = ref(null)
const display_icon = ref(null)
const showAdvanced = ref(false)
const creating = ref(false)
const showSnapshots = ref(false)
const creationType = ref('custom')
Expand All @@ -248,7 +237,6 @@ defineExpose({
specified_loader_version.value = ''
profile_name.value = ''
creating.value = false
showAdvanced.value = false
showSnapshots.value = false
loader.value = 'vanilla'
loader_version.value = 'stable'
Expand Down Expand Up @@ -417,10 +405,6 @@ const selectable_versions = computed(() => {
return []
})

const toggle_advanced = () => {
showAdvanced.value = !showAdvanced.value
}

const openFile = async () => {
const newProject = await open({ multiple: false })
if (!newProject) return
Expand Down