Skip to content

Support missing ClickHouse connection #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fetchfern
Copy link
Collaborator

This lets labrinth handle not being able to connect to ClickHouse. Useful for staging/local environments.

If the CLICKHOUSE_HARD_FAIL environment variable is set, labrinth will crash if a ClickHouse connection cannot be established.

cursor/gpt-5 wrote most of this

Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned on Slack, a better way to address the disk space issues we're seeing in the staging environment due to Clickhouse may be to periodically delete old data. I've confirmed this should not cause problems with Labrinth, aside from resetting download counts and analytics, which we don't treat as persistent anyway. This approach would help keep configuration drift between environments to a minimum, which is widely considered a good practice.

If periodic data cleanup turns out to be too time-consuming, or if address this issue is urgent, we could merge this PR. However, I'd prefer to do that as a last resort, once better options are exhausted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants