-
Notifications
You must be signed in to change notification settings - Fork 336
Analytics backend V2 #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Analytics backend V2 #4408
Conversation
a9d6d5d
to
0a9ea34
Compare
39c4f0b
to
f35f4b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the InvalidInput error messages aren't consistent with the rest of the codebase (all lowercase, using "-"). Looks fine to me other than that
8750a4e
to
78720b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in #4445, we should be placing these SQLx metadata files in the Labrinth project folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the sqlx folder from root and moved it to apps/labrinth, although the github diff view shows that sqlx files have been removed from root sqlx (which doesn't exist on main..?)
8b9b26b
to
4e54e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes DEV-277