Skip to content

Conversation

aecsocket
Copy link
Contributor

Fixes DEV-277

@aecsocket aecsocket marked this pull request as ready for review September 26, 2025 07:41
Copy link
Contributor

@fetchfern fetchfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the InvalidInput error messages aren't consistent with the rest of the codebase (all lowercase, using "-"). Looks fine to me other than that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in #4445, we should be placing these SQLx metadata files in the Labrinth project folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the sqlx folder from root and moved it to apps/labrinth, although the github diff view shows that sqlx files have been removed from root sqlx (which doesn't exist on main..?)

Copy link
Contributor

@fetchfern fetchfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prospector Prospector added this pull request to the merge queue Oct 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants