refactor(app): reduce tech debt by eliminating wry
fork
#4500
+31
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We currently maintain our own fork of
wry
with three significant changes:WebviewWindowBuilder#initialization_script_for_all_frames
method.Webview#with_webview
method and calling the corresponding native API.WebviewBuilder#on_new_window
method.Since all these changes can now be implemented using standard APIs that don't require forking, and our
wry
fork is no longer being used in the latest release version (someone updated ourCargo.lock
to use a newer upstream version, causing a build warning about the unused patch), this PR implements these changes using the discussed standard APIs, eliminating the maintenance burden of keeping our fork up to date, and preventing such patching failures from going unnoticed in the future.