rector to PHP 8.4, disable mcrypt encryption driver#28
Draft
mbolli wants to merge 1 commit intomodufolio:mainfrom
Draft
rector to PHP 8.4, disable mcrypt encryption driver#28mbolli wants to merge 1 commit intomodufolio:mainfrom
mbolli wants to merge 1 commit intomodufolio:mainfrom
Conversation
Owner
|
Hi Michael, sorry for my late response, I'm recovering from a burnout. Thank you for your help. Please split this PR in 3 or multiple PR's. One for style changes like the formatting of arrays (as you suggested). Please create an PR too that only consist the needed changes to make Koken work on PHP8.4. Changes to the datamapper should always be a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
#[\Override]attributes where neededmcrypt_get_iv_size(),mcrypt_encrypt()etc. got removed with PHP 7.2)todo
#[\Override]as optional and PHP 8.3 neededExplicitNullableParamTypeRectordid not skip anythingbugs
I was always using albums within albums and this is the condition to display the arrow:
Koken-App/admin/templates/library.tmpl.html
Line 415 in 97d3cc9