Skip to content

Replace url_override with base_url #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Replace url_override with base_url #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions mojo/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ _NULL_SHAS = {
}

def _mojo_toolchain_impl(rctx):
base_url = rctx.attr.base_url or "https://dl.modular.com/public/nightly/python"
rctx.download_and_extract(
url = rctx.attr.url_override or "https://dl.modular.com/public/nightly/python/max-{}-py3-none-{}.whl".format(
url = "{}/max-{}-py3-none-{}.whl".format(
base_url,
rctx.attr.version,
_PLATFORM_MAPPINGS[rctx.attr.platform],
),
Expand Down Expand Up @@ -60,8 +62,8 @@ _mojo_toolchain_repository = repository_rule(
values = _PLATFORMS,
mandatory = True,
),
"url_override": attr.string(
doc = "Override the download URL for the prebuilt package.",
"base_url": attr.string(
doc = "Override the base download URL for the prebuilt package.",
default = "",
),
"use_prebuilt_packages": attr.bool(
Expand Down Expand Up @@ -115,7 +117,7 @@ def _setup_toolchains(root_module, rules_mojo_module):
name = name,
version = tags.version,
platform = platform,
url_override = tags.url_override,
base_url = tags.base_url,
use_prebuilt_packages = tags.use_prebuilt_packages,
)

Expand Down Expand Up @@ -165,8 +167,8 @@ _toolchain_tag = tag_class(
doc = "The version of the Mojo toolchain to download.",
default = _DEFAULT_VERSION,
),
"url_override": attr.string(
doc = "Override the download URL for the prebuilt package.",
"base_url": attr.string(
doc = "Override the base download URL for the prebuilt package.",
default = "",
),
"use_prebuilt_packages": attr.bool(
Expand Down