Conversation
KaidanTheron
requested changes
Aug 8, 2025
Collaborator
KaidanTheron
left a comment
KaidanTheron
left a comment
There was a problem hiding this comment.
As discussed:
- remove default logger
- just pass extended job metadata to logger
KaidanTheron
requested changes
Aug 11, 2025
Collaborator
KaidanTheron
left a comment
KaidanTheron
left a comment
There was a problem hiding this comment.
i think we are almost there, I don't think we need to be using the logging protocol anymore though. If everything is tested we can merge this bad boy once you remove the deprecated logging protocol
KaidanTheron
approved these changes
Aug 11, 2025
Collaborator
KaidanTheron
left a comment
KaidanTheron
left a comment
There was a problem hiding this comment.
Sweet. Merge if everything is tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional logging protocol that provides a default implementation should one not be provided.
Updated the build workflow to use deps-deploy to deploy the project to clojars. In the current workflow, you have to run
clj -T:build build/jar, which generates the jar, then you have to runclj -Spomwhich generates a pom.xml file and finallyclj -T:build build/deploywhich will deploy to clojars provided you have CLOJARS_USERNAME and CLOJARS_PASSWORD as environment variables. Deployment is currently untested.