revert backend_thumb_height to 100 #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I'm missing something here but the change of the default system setting for thumb height made in 1c34331 from 100 to 80 just seem off to me. It just looks like the image did not load properly since the outer box is 100px. So I'll suggest a revert back to a hight of 100px.
See pic, manualy changed the url to get a 100px high image for the first one.
This was tested on a clean modx 2.3.1-pl install with Gallery 1.7.0-pl from the Package Manager "Installed on Sep 20, 2014 06:21 PM"