v1.2.1

[moehrem]

bugfix: API key in API ClientError message wasnt redacted
feature: added custom base API URL config and reconfig option
change: refactored config_flow navigation for better readability
feature: updated tests to work with configurable base url
redefined services.yaml to match HA standards

[Copilot]

Pull Request Overview

This PR refactors the API configuration to support customizable base URLs by introducing a base_api_url parameter throughout the codebase. The version is bumped from 1.2.0 to 1.2.1.

• Adds base_api_url parameter to API initialization, credential validation, and configuration flows
• Refactors API request handling to separate URL construction from endpoint paths
• Replaces menu-based config flow with form-based selection for better error display
• Removes device targets from service definitions, keeping only entity targets

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
custom_components/diveracontrol/manifest.json	Updates version from 1.2.0 to 1.2.1
custom_components/diveracontrol/const.py	Adds D_BASE_API_URL constant for the new parameter
custom_components/diveracontrol/init.py	Extracts and passes base_url parameter to DiveraAPI initialization; updates migration logic
custom_components/diveracontrol/divera_api.py	Refactors API request method to accept partial URLs and construct full URLs using base URL; improves error messages
custom_components/diveracontrol/divera_credentials.py	Adds base_api_url parameter to validation methods
custom_components/diveracontrol/config_flow.py	Replaces menu with form-based method selection; adds base URL field to all configuration forms; improves error handling
custom_components/diveracontrol/translations/*.json	Updates translations to support form-based method selection and adds base URL field labels
custom_components/diveracontrol/services.yaml	Removes device targets from service definitions, keeping only entity targets
tests/test_*.py	Updates tests to pass BASE_API_URL parameter and adjusts assertions for config flow changes

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The base URL extraction uses or \"\" which will result in an empty string if D_BASE_API_URL is not in config_entry.data (e.g., for existing installations upgrading to this version). This will cause API requests to fail. Consider providing a fallback to BASE_API_URL constant: base_url: str = config_entry.data.get(D_BASE_API_URL, BASE_API_URL)

[Copilot]

Accessing err.url.path_qs assumes that the ClientError has a url attribute with a path_qs property. This may not always be the case depending on the type of ClientError. Consider adding a check or try-except block to handle cases where err.url is None or doesn't have path_qs attribute to avoid AttributeError.

Suggested change

	url = self._redact_url(err.url.path_qs)
	# Safely access err.url.path_qs if available
	if hasattr(err, "url") and err.url is not None and hasattr(err.url, "path_qs"):
	url = self._redact_url(err.url.path_qs)
	else:
	url = self._redact_url(str(getattr(err, "url", "Unknown URL")))

[Copilot]

The reconfigure flow now assumes async_get_entry() will always return a valid ConfigEntry and assigns it directly. If the entry doesn't exist, this will raise an AttributeError instead of returning None. The previous code handled the None case explicitly. Consider adding a null check: if not config_entry: return self.async_abort(reason=\"hub_not_found\") or use the previous try-except pattern.

Suggested change

	config_entry: ConfigEntry = self.hass.config_entries.async_get_entry(entry_id)
	config_entry: ConfigEntry = self.hass.config_entries.async_get_entry(entry_id)
	if not config_entry:
	return self.async_abort(reason="hub_not_found")

[Copilot]

The code attempts to access self.cur_step which is not a documented attribute of ConfigFlow. This appears to be trying to determine the current step, but cur_step is not a standard ConfigFlow attribute. This may cause AttributeError. Consider passing the step_id as a parameter to _validate_and_proceed or using a different approach to track which form the user is on.