Merged
Conversation
HadronCollider
force-pushed
the
water_in_the_text_check
branch
from
c9102ea to
eb788d9
Compare
HadronCollider
requested changes
Apr 10, 2025
Comment on lines
+35
to
+42
| if self.watery_phrase_density(text, words) > self.watery_phrase_threshold: | ||
| result_str += f"В Разделе '{chapter['text']}' содержится более {self.watery_phrase_threshold*100}% 'водянистых' фраз.<br>" | ||
|
|
||
| if self.long_sentences_density(text) > self.long_sentence_threshold: | ||
| result_str += f"В разделе '{chapter['text']}' более {self.long_sentence_threshold*100}% предложений длиннее 20 слов.<br>" | ||
|
|
||
| if self.meaningful_word_density(words) < self.meaningful_word_threshold: | ||
| result_str += f"В разделе '{chapter['text']}' доля значимых слов составляет менее {self.meaningful_word_threshold*100}% от общего количества слов.<br>" |
Collaborator
There was a problem hiding this comment.
Тут в фидбек нужно что-то похожее #647 (comment)
- вывести сами плохие фразы / слова, чтобы было понятно о чем речь (а не гадать где там и что)
- дать инструкцию что с этим сделать и как исправить
| result_str += f"В Разделе '{chapter['text']}' содержится более {self.watery_phrase_threshold*100}% 'водянистых' фраз.<br>" | ||
|
|
||
| if self.long_sentences_density(text) > self.long_sentence_threshold: | ||
| result_str += f"В разделе '{chapter['text']}' более {self.long_sentence_threshold*100}% предложений длиннее 20 слов.<br>" |
Collaborator
There was a problem hiding this comment.
насколько "20 слов" могут (или должны) быть захардкоржены? Привязано ли это число к размеру long_sentence_threshold
Collaborator
|
Устраните конфликты |
HadronCollider
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.