Skip to content

fix(settings): clear previous provider highlight on selection#73

Open
SH20RAJ wants to merge 2 commits intomofa-org:mainfrom
SH20RAJ:fix/58-provider-single-select-highlight
Open

fix(settings): clear previous provider highlight on selection#73
SH20RAJ wants to merge 2 commits intomofa-org:mainfrom
SH20RAJ:fix/58-provider-single-select-highlight

Conversation

@SH20RAJ
Copy link
Copy Markdown

@SH20RAJ SH20RAJ commented Mar 28, 2026

Summary

Fixes provider selection behavior in Settings -> Providers so only one provider appears selected at a time.

Issue

Closes #58

Root Cause

Provider selection logic was overriding background color directly, while ProviderItem rendering is controlled by shader instance states for selected and hover. That mismatch allowed stale visual states to accumulate.

Changes

  • Reset built-in provider items using selected = 0 and hover = 0
  • Mark the chosen provider with selected = 1
  • Keep custom provider selection and hover state aligned the same way
  • Update dark-mode redraw path to preserve selected-state semantics for built-in and custom providers

GSoC Ideas Alignment

This contributes to MoFA Studio UX quality under the GSoC ideas list where mofa-studio is involved (Idea 2 / Studio HCI and observability surface quality).

Validation

  • Static code review completed
  • Could not run cargo checks in this environment because cargo is unavailable (command not found)

SH20RAJ added 2 commits March 28, 2026 20:25
Fix typo 'setings' -> 'settings' in the benefits section of TabId enum documentation.
@SH20RAJ
Copy link
Copy Markdown
Author

SH20RAJ commented Mar 29, 2026

Checked status: this PR is pending maintainer review/merge from upstream maintainers. I’m available to address feedback quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI Bug] Provider selection in Settings does not clear previous highlight

1 participant