fix(foundation): reuse reqwest::Client in HttpTool to prevent connection pool leaks#1575
Open
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Open
fix(foundation): reuse reqwest::Client in HttpTool to prevent connection pool leaks#1575SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
SH20RAJ wants to merge 1 commit intomofa-org:mainfrom
Conversation
Contributor
Author
|
Friendly ping! This PR reuses reqwest::Client in HttpTool to prevent connection pool leaks. Network resource leak fix. @yangrudan @lijingrs review appreciated 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1542 - HttpTool::execute() was creating a new reqwest::Client on every invocation, preventing connection pool reuse and causing resource leaks.
Problem
The reqwest::Client is explicitly documented as a type that must be reused across requests. It holds:
Creating a new client per call meant:
Solution
Replace the per-invocation Client::new() with a shared static client using once_cell::Lazy. This ensures:
Testing
This fix is compatible with all existing HttpTool tests (no behavior change, only internal resource management). CI should verify no regressions.
GSOC 2026 Contribution
This addresses priority P1 issue #1542, demonstrating expertise with performance-critical optimizations and Rust async patterns.
Cc: @Mustafa11300 @rahulkr182